In a recent post, I said: That second patch uses the same string you saw above in the previous patch. Yes, it would be better to have added that string to just one place. I welcome patches for that change. Today I will show you that code. With help from Matthias Andree on IRC, I […]
Adding code, removing more code to reduce duplication Read More »
Earlier today, I wrote about a fix which broke search. At the end of that post, I mentioned a few things which needed to be done to fix up the broken relationships. clean up the database add a foreign key, on delete set null trigger to find the right value when set null Let’s get
Fixing up a referential integrity issue Read More »
Bernard emailed me, and Tim Stoddard posted in the forum about search not finding what it should find. I quickly agreed; it was wrong. Fortunately, it was a small fix. See also my follow-up post where I fixed the broken data. The problem The problem was searching for ports such as bird didn’t include that
Bad SQL corrupts search results Read More »
I recently wrote about a problem with FreshPorts not tracking changes by branch. I recently patched the dev system and things are looking better. The patch is: This change forces the code to look for an existing row in the system_branch_element_revision table, and if not found, add it in. I used this commit against news/trn4
Tracking port changes by branch – first fix Read More »
Back in 2007, perhaps earlier, I wrote a Python script which listens for various PostgreSQL events. In particular, this script will invalidate the cache for a port when it is updated. There are several other such tasks, such as the creation of a new category. When the commit processing daemon (freshports) detects that a new
Listening daemon out of date Read More »
This article was originally written in September 2012, but never published. I’m publishing it today, much later than expected. I started looking at how to create these new directories as mentioned yesterday. This starts the process: $ psql freshports.org psql (9.0.8, server 9.0.9) Type “help” for help. freshports.org=# select Element_Add(‘/base/head’, ‘D’); element_add ————- 453742 (1
Creating the new repo base directories Read More »
If a vuxml entry is updated, and the ranges change, those changes are not recorded in FreshPorts. This came to my attention from the FreeBSD Security team. They noticed that for the recent Oracla Java vuln FreshPorts had all versions for > 7. It boiled down to this: http://www.freshports.org/vuxml.php?vid=16846d1e-f1de-11e1-8bd8-0022156e8794 [1] differs from this: http://www.vuxml.org/freebsd/16846d1e-f1de-11e1-8bd8-0022156e8794.html [2]
Updates to vuxml ranges fails Read More »
Before the last post was published, I forgot to add in the fix for the pathname problem. freshports.org=# select ElementPathnameUpdateChildren(453745); It run. A long time. I let it run. For hours. About 16 hours. Then I killed it. I checked the procedure. It made sense. Then I checked the update statement: freshports.org=# explain analyse UPDATE
An index can make all the difference Read More »
I started looking at how to create these new directories as mentioned yesterday. This starts the process: $ psql freshports.org psql (9.0.8, server 9.0.9) Type “help” for help. freshports.org=# select Element_Add(‘/base/head’, ‘D’); element_add ————- 453742 (1 row) freshports.org=# select Element_Add(‘/doc/head’, ‘D’); element_add ————- 453743 (1 row) freshports.org=# select Element_Add(‘/ports/head’, ‘D’); element_add ————- 0 (1 row)
Creating the new repo base directories Read More »
This issue was brought to my attention by wxs (Wesley Shields). The issue is evident at http://www.freshports.org/graphs2.php. When you get there, click on click on Commits Over Time by Committer and then wait for the page to load. Scroll down to the D’s. There you’ll see a few committers suffixed with ‘(ports committer)’. Looking in
The committer field is not always an email address Read More »