The committer field is not always an email address

This issue was brought to my attention by wxs (Wesley Shields). The issue is evident at http://www.freshports.org/graphs2.php. When you get there, click on click on Commits Over Time by Committer and then wait for the page to load.

Scroll down to the D’s. There you’ll see a few committers suffixed with ‘(ports committer)’.

Looking in the database, we see:

$ psql freshports.org 
psql (8.4.7)
Type "help" for help.

freshports.org=# select committer, message_id, commit_date from commit_log where committer like '%ports committer%' order by commit_date desc;
        committer         |                 message_id                  |      commit_date       
--------------------------+---------------------------------------------+------------------------
 rea (ports committer)    | 201110280603.p9S63cVj045250@svn.freebsd.org | 2011-10-28 07:03:38+01
 eadler (ports committer) | 201110172131.p9HLV3xL041492@svn.freebsd.org | 2011-10-17 22:31:03+01
 eadler (ports committer) | 201110161430.p9GEUTFj066335@svn.freebsd.org | 2011-10-16 15:30:29+01
 eadler (ports committer) | 201110152106.p9FL684c030644@svn.freebsd.org | 2011-10-15 22:06:08+01
 rakuco (ports committer) | 201110132036.p9DKaiNi031421@svn.freebsd.org | 2011-10-13 21:36:44+01
 crees (ports committer)  | 201110081825.p98IP22D073560@svn.freebsd.org | 2011-10-08 19:25:02+01
 wxs (ports committer)    | 201110061613.p96GDlZk068019@svn.freebsd.org | 2011-10-06 17:13:47+01
 eadler (ports committer) | 201109282142.p8SLgDCV090941@svn.freebsd.org | 2011-09-28 22:42:13+01
 eadler (ports committer) | 201109282046.p8SKkqQT089293@svn.freebsd.org | 2011-09-28 21:46:52+01
 eadler (ports committer) | 201109281856.p8SIu2n2085649@svn.freebsd.org | 2011-09-28 19:56:02+01
 eadler (ports committer) | 201109281849.p8SInbrJ085366@svn.freebsd.org | 2011-09-28 19:49:37+01
 crees (ports committer)  | 201109281703.p8SH3n8r082164@svn.freebsd.org | 2011-09-28 18:03:49+01
 cs (ports committer)     | 201109162257.p8GMvowd042057@svn.freebsd.org | 2011-09-16 23:57:50+01
(13 rows)

freshports.org=# 

Looking at one of these commits (the one by wxs), we see it is a source commit, as opposed to a port commit.

The original commit email contains that ‘(ports committer)’ text.

Ideally, the FreshPorts software would strip this value from the committer field before storing it in the database. It could also set a flag on that commit to highlight this particular situation.

It seems the fix is easy enough:

freshports.org=# update commit_log set committer = replace(committer, ' (ports committer)', '')  where committer like '%ports committer%';
UPDATE 13

But it seems the problem is more widespread than that:

freshports.org=# select committer, message_id, commit_date from commit_log where committer like '% committer%' order by commit_date desc;
       committer        |                 message_id                  |      commit_date       
------------------------+---------------------------------------------+------------------------
 wblock (doc committer) | 201110140034.p9E0Yks5038994@svn.freebsd.org | 2011-10-14 01:34:46+01
 gjb (doc committer)    | 201110101123.p9ABNnDV057799@svn.freebsd.org | 2011-10-10 12:23:49+01
 gjb (doc committer)    | 201110101123.p9ABNJuE057749@svn.freebsd.org | 2011-10-10 12:23:19+01
 gjb (doc committer)    | 201110101115.p9ABFvON057412@svn.freebsd.org | 2011-10-10 12:15:57+01
 gjb (doc committer)    | 201110101114.p9ABEiVK057324@svn.freebsd.org | 2011-10-10 12:14:44+01
 gjb (doc committer)    | 201110101114.p9ABE3go057270@svn.freebsd.org | 2011-10-10 12:14:03+01
 gjb (doc committer)    | 201110101112.p9ABCejq057184@svn.freebsd.org | 2011-10-10 12:12:40+01
 gjb (doc committer)    | 201110101111.p9ABBx3e057123@svn.freebsd.org | 2011-10-10 12:11:59+01
 gjb (doc committer)    | 201110101111.p9ABB5M8057060@svn.freebsd.org | 2011-10-10 12:11:05+01
 gjb (doc committer)    | 201110101107.p9AB7anG056904@svn.freebsd.org | 2011-10-10 12:07:36+01
 gjb (doc committer)    | 201110101106.p9AB6nRm056835@svn.freebsd.org | 2011-10-10 12:06:49+01
 gjb (doc committer)    | 201110101105.p9AB5wIj056772@svn.freebsd.org | 2011-10-10 12:05:58+01
 gjb (doc committer)    | 201110092021.p99KL7kn025209@svn.freebsd.org | 2011-10-09 21:21:07+01
 gjb (doc committer)    | 201110021605.p92G5JXb070257@svn.freebsd.org | 2011-10-02 17:05:19+01
 gjb (doc committer)    | 201110012347.p91NlbkK038750@svn.freebsd.org | 2011-10-02 00:47:37+01
 gjb (doc committer)    | 201110012056.p91KuwwX033481@svn.freebsd.org | 2011-10-01 21:56:58+01
 wblock (doc committer) | 201109290337.p8T3bgwv002749@svn.freebsd.org | 2011-09-29 04:37:42+01
 gjb (doc committer)    | 201109290257.p8T2v86W001175@svn.freebsd.org | 2011-09-29 03:57:08+01
 gjb (doc committer)    | 201109290252.p8T2qXbO000985@svn.freebsd.org | 2011-09-29 03:52:33+01
 gjb (doc committer)    | 201109290229.p8T2TWYt000206@svn.freebsd.org | 2011-09-29 03:29:32+01
 gjb (doc committer)    | 201108310118.p7V1IN05074751@svn.freebsd.org | 2011-08-31 02:18:23+01
 gjb (doc committer)    | 201108310117.p7V1Hnam074693@svn.freebsd.org | 2011-08-31 02:17:49+01
 marck (doc committer)  | 201108301149.p7UBnMHr050082@svn.freebsd.org | 2011-08-30 12:49:22+01
 marck (doc committer)  | 201108301147.p7UBla7E049983@svn.freebsd.org | 2011-08-30 12:47:36+01
 gjb (doc committer)    | 201108241218.p7OCITW1053854@svn.freebsd.org | 2011-08-24 13:18:29+01
 marck (doc committer)  | 201108232025.p7NKPBBR018175@svn.freebsd.org | 2011-08-23 21:25:11+01
(26 rows)

freshports.org=# 
Website Pin Facebook Twitter Myspace Friendfeed Technorati del.icio.us Digg Google StumbleUpon Premium Responsive

Leave a Comment

Scroll to Top