Wrong path on src commits

Wesley Shields (wxs@) wrote in to point out that the commits for Mk/bsd.sites.mk where not showing up correctly.

Not sure if you know about this or not but it appears that (at least)
Mk/bsd.sites.mk is not being properly updated on freshports since August
5.

I compared these two URLS:

1. http://www.freshports.org/Mk/bsd.sites.mk
2. http://dev.freshports.org/Mk/bsd.sites.mk

Yep. The full commits were displayed at dev, but not www.

Comparing the commits on each site:

1. http://www.freshports.org/commit.php?message_id=201208201610.q7KGAvxm059305@svn.freebsd.org
2. http://dev.freshports.org/commit.php?message_id=201208201610.q7KGAvxm059305@svn.freebsd.org

.. both have same results.

However, the DB tells the story:

on prod:

freshports.org=# select *, element_pathname(element_id) from commit_log_elements where commit_log_id = (select id from commit_log where message_id = '201208201610.q7KGAvxm059305@svn.freebsd.org');
   id    | commit_log_id | element_id | revision_name | change_type |    element_pathname    
---------+---------------+------------+---------------+-------------+------------------------
 1929657 |        445170 |      77711 | 302820        | M           | /ports/Mk/bsd.sites.mk
(1 row)

freshports.org=# 

on dev:

freshports.org=# select *, element_pathname(element_id) from commit_log_elements where commit_log_id = (select id from commit_log where message_id = '201208201610.q7KGAvxm059305@svn.freebsd.org');
   id    | commit_log_id | element_id | revision_name | change_type |    element_pathname    
---------+---------------+------------+---------------+-------------+------------------------
 1907930 |        445108 |      77711 | 302820        | M           | /ports/Mk/bsd.sites.mk
(1 row)

freshports.org=# 

Oh. They are the same. I was fearing different paths were being used. e.g. /head/ports/Mk, for example.

There can be only on explanation now. Caching?

Yes. It was caching. The Observer class for the caching was not being notified correctly.

So why did dev get it right and www get it wrong? Timing. Nobody had viewed the page on dev… many people had viewed the page on www, so it had been cached since before 5 August.

Solution: fix the notifier so it lets the Observer know the cach needs to be cleared.